Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime, media and link output in xhtml renderer is adjusted, to show title text instead when src/href is null. In interwiki case, the title will be the "reference" part of the interwiki link.

This makes it possible to also support no URL cases in `interwiki.conf`. Before it will output a URL as `rawurlencode($reference)`, which doesn't make too much sense since it's encoded. However, I am not sure the use case under the current behavior (no URL, but text as `$reference`).

Docs needs to be added to warn renderer plugin developers of this situation.

This fixes #2588.

show more ...

Merge branch 'master' into psr2

changes from commit b15f23f6735eabb6dc7e4a996e4ae164139ab7f5 may have
been lost, because the code changed to much.

changes from commit df81ca99eeaf4753d6f09cbddbb529

Merge branch 'master' into psr2

changes from commit b15f23f6735eabb6dc7e4a996e4ae164139ab7f5 may have
been lost, because the code changed to much.

changes from commit df81ca99eeaf4753d6f09cbddbb529afe7ef71c7 need to be
verified. we might need to do some more adjustments.

* master: (49 commits)
translation update
translation update
translation update
translation update
translation update
translation update
translation update
Update config.class.php
translation update
translation update
Update lang.php
Add ugc hint to nofollow
add UGC hint
translation update
translation update
use a script to fetch the correct phpunit
Revert "output travis php version for easier debugging"
setup databases for unit tests in travis
output travis php version for easier debugging
translation update
...

show more ...

Add ugc hint to nofollow

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

split changelog classes into their own namespace

The remaining functions in inc/changelog.php should be moved into a
utility class.

visibility definition for the renderers

I made a lot of things public that probaly should be protected. But many
syntax plugins do access renderer mechanisms directly, so better stay on
the safe sid

visibility definition for the renderers

I made a lot of things public that probaly should be protected. But many
syntax plugins do access renderer mechanisms directly, so better stay on
the safe side here.

The base renderer is now abstract.

show more ...

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

remove DOKU_INC checks

There is no need for this check, since these files should not have any
main code that is executed on direct call.

Fixes PSR1.Files.SideEffects.FoundWithSymbols

Merge pull request #2307 from splitbrain/geshi_features

Geshi Option parsing

Merge pull request #2312 from splitbrain/seceditfallback

fallback for new section editing. fixes #2311

Prevent HTML and JS injection in section names

Before this change, HTML and some JS code (as far as it was not escaped
by json_encode) could be injected into the output as the closing pattern
that i

Prevent HTML and JS injection in section names

Before this change, HTML and some JS code (as far as it was not escaped
by json_encode) could be injected into the output as the closing pattern
that is checked by the regex is not escaped in JSON (see test case).

show more ...

fallback for new section editing. fixes #2311

The displayed message now shows the target that was passed, which should
help identifying the troubling plugin.

Instead of failing, we fix the data our

fallback for new section editing. fixes #2311

The displayed message now shows the target that was passed, which should
help identifying the troubling plugin.

Instead of failing, we fix the data ourselves - this code will be
removed in the future.

show more ...

Merge branch 'private_testing' into geshi_features

* private_testing: (375 commits)
make testing of inaccessible methods easier
updated composer dependencies
renamed ActionRouter::checkPermiss

Merge branch 'private_testing' into geshi_features

* private_testing: (375 commits)
make testing of inaccessible methods easier
updated composer dependencies
renamed ActionRouter::checkPermissions to checkPreconditions
shortened new search configs
Section edit: corrected pattern 'SEC_EDIT_PATTERN'
fix regex character class. fixes #2301
fix: switch extensions if stylesheet in style.ini doesn't exist
refactor: rename and move function to set $JSINFO
typo. capital P for class name
fix: add missing global $ACT for $JSINFO
refactor: use native json_encode for $JSINFO
refactor: rename JSINFO.DOKU_UHN and JSINFO.DOKU_UHC
refactor: extract $JSINFO initialization into tpl_ function
refactor: rename dta and dtb parameters
doc(search): parameter must be string or false
doc(search): highlight is expected to be an array
show adavanced tools with JavaScript only
adjusted language files to remove outdated string
removed sub header from all languages
added aria attributes
...

show more ...

Refactored section edit

The data for the section edit button is now passed as an assoziative array which is
encoded in the '#<!-- EDIT(.*) -->#' placeholder as an JSON array.

Merge pull request #2077 from schplurtz/vtt-tracks

Support Web Video Text Tracks Format subtitles

fix inconsistent use of rawurlencode

fix xhtml:internallink $params usage, fixes #2188
not perfect, but it works

protect strings that depend on uploaded file name

fix: fix regex to return table secedit buttons

Since the hid is optional, it must also be optional in the regex. Also
this commit introduced named capture groups to make it more obvious
which part o

fix: fix regex to return table secedit buttons

Since the hid is optional, it must also be optional in the regex. Also
this commit introduced named capture groups to make it more obvious
which part of the regex captures what.

Also there is now an explicit hid generated for tables, to enable
jumping to the correct section after finishing editing.

This was broken in 2571786c763e04c7abbf27c2245a5720878dc3f1 or #1966
respectively.

Known Issues:
* since both title and hid are optional, a hid may be misinterpreted as
a title if the title is not generated.

show more ...

use only language code, no language name

Merge pull request #1933 from splitbrain/actionrefactor

Action Dispatch Refactoring

Merge pull request #2089 from phy25/fix-2080

Fix rendering null $language going to GeSHi (fixes #2088)

Fix rendering null $language going to GeSHi (fixes #2088)

Merge pull request #2086 from phy25/fix-2081 CVE-2017-12980

Fix RSS syntax XSS bug (#2081)

Fix RSS syntax XSS bug (#2081)