codestyle adjustments: function declaration braces/spaces

codestyle adjustments: function argument spacing

Apply rector fixes to the rest of inc

use samesite=Lax cookie attribute #2849

Since this has been the default in Chrome for a while, no sideeffects
are to be expected.

output full path when initializing savedir path fails

This will not only clean up double slashes etc. as mentioned in #3903
but will also output the full canonical path (starting at the filesystem
r

output full path when initializing savedir path fails

This will not only clean up double slashes etc. as mentioned in #3903
but will also output the full canonical path (starting at the filesystem
root) when showing an error on initializing the savedir paths. This
should make it easier to understand which path DokuWiki is trying to
access exactly.

show more ...

Adds a new DOKUWIKI_INIT_DONE event

This is a simple event called at the very end of the inc/init.php
process. It provides an alternative to DOKUWIKI_STARTED that is always
executed regardless of th

Adds a new DOKUWIKI_INIT_DONE event

This is a simple event called at the very end of the inc/init.php
process. It provides an alternative to DOKUWIKI_STARTED that is always
executed regardless of the called script (eg. in lib/exe/ajax.php or in
endpoints provided by plugins).

show more ...

:fire: fix the calculation of file permissons

Our config allows to set the values for `dmode` and `fmode` to allow
users to explicitly define which permissions directories and files
should have.

To

:fire: fix the calculation of file permissons

Our config allows to set the values for `dmode` and `fmode` to allow
users to explicitly define which permissions directories and files
should have.

To avoid unnessary chmod operations, we check the current umask to
compare what permissions files and directories would get witout our
intervention. If the result is already what the user wants, no chmods
will happen later on. Otherwise we set new configs called `dperm` and
`fperm` which will be used in chmod ops. This is done in
`init_creationmodes()`

When we created new directories, we used to pass the original `dmode`
config to `mkdir()`. The system will then apply the umask to that
`dmode`.

This means the resulting directory will *always* have different
permissions than `dmode`, *always* requiring a chmod operation.
That's silly.

**Breaking Change:** This patch removes the passing of `dmode` as
second parameter to all `mkdir` calls, making it default to `0700`
which is also what we test against in `init_creationmodes()`.

Plugins not relying on our `io_*` functions and do create their own
directories and which currenlty pass `dmode` to it need to be
adjusted to remove that second parameter.

Users may want to reapply the proper file permissions to their data
folder.

**Revert:** In 9fdcc8fcd87114ca59a1764a84d213a53c655c8c @movatica
introduced a change to `init_creationmodes()` that compared the umask
against `fmode` instead of `0666`. I merged it because it looked logical
when compared to the code for directories which compared against `dmode`
as described above. However we do not pass `fmode` to any file creation
methods (that's not possible).

The result is that all changes made in the `fmode` setting resulted
in the wrong permissions for newly created files as first reported in
https://forum.dokuwiki.org/d/19463-setting-fmode-not-working-as-intended

I'm unsure about the orginal motivation behind @movatica's change. The
"fix" however, is wrong.

**Tests:** This patch introduces an integration test that will check the
actual results of directory and file creations under various umask,
`dmode` and `fmode` settings.

show more ...

Fix Undefined array key "fperm" warning

Also removed a few, now unnecessary `!empty` checks

Fixes #3382

central logging mechanism

This introduces a logger mechanism and a new data/log directory. This is
a first proof of concept. It's built on top of the new global error
handling mechanism

Things to d

central logging mechanism

This introduces a logger mechanism and a new data/log directory. This is
a first proof of concept. It's built on top of the new global error
handling mechanism

Things to discuss:

* should we adopt PSR-3 somehow? if yes, how and should plugins be able
to drop-in other psr3 loggers?
* how to configure which facilities shall be logged?
* should we implement a log deletion feature?
* is the log format sensible?
* should we implement a log viewer admin plugin?
* should logging trigger events (it should maybe replace the
deprecation event)

show more ...

introduce a global error handler

This transfers old style PHP errors into Exceptions and installs a
global exception handler. All exceptions caught by this handler are
logged to an error log and a m

introduce a global error handler

This transfers old style PHP errors into Exceptions and installs a
global exception handler. All exceptions caught by this handler are
logged to an error log and a meassage is shown to the end user. This
should finally get rid of "blank page" bug reports.

show more ...

Respect fmode config setting

Fix hardcoded fmode overriding user config, which breaks with nondefault environments.

Fixed inconsistent handling of falsy values on fperm setting

The $conf['fperm'] value was checked in multiple files using different methods.
This can cause permission trouble with restricted environ

Fixed inconsistent handling of falsy values on fperm setting

The $conf['fperm'] value was checked in multiple files using different methods.
This can cause permission trouble with restricted environments, i.e. when chmod is forbidden and file permissions are non-default.
Now, all checks use implicit cast to boolean which leads to consistent behaviour.

Also, a misleading variable was renamed in context to better understand one of the checks.

show more ...

Fix curly brace syntax. PHP 7.3 deprecations in inc/ directory.

Move list of plugin types to plugin controller constant

There is no need to have them in a global variable.

moved plugin controller to Extension namespace

deprecated trigger_event() in favor of a static method on Event

First go at moving the plugin classes into their own namespace

Merge branch 'master' into psr2

* master: (22 commits)
Support "local" subdir when listing the smiley directory
fix zero ID/NS issue with page_findnearest
add ID/NS = '0' test against page_fin

Merge branch 'master' into psr2

* master: (22 commits)
Support "local" subdir when listing the smiley directory
fix zero ID/NS issue with page_findnearest
add ID/NS = '0' test against page_findnearest
fix zero value issue with metadata indexer
add key/value = '0' test to metadata indexer
fix zero ID issue with linkwiz and search indexer
fix zero ID issue with wl() and getID()
add $ID = '0' test against wl() and getID()
cookie.js when setValue‘s value parameter is false delete entry
install.php: respect useacl=0 choice, fixes #2576
cookie.js add def parameter to getValue()
cookie.js convert value type to string
set_doku_pref bugfix, closes #2721
more definition tests of doku_pref, for #1129
add tests for get/set_doku_pref #2721
fix Windows tests for #2702
use absolute URL in index.php when redirecting to doku.php, fixes #2706
Adding "recursive_groups" setting for authad-plugin in configuration-manager
Fix notices when using dw CLI
Fix issue #2396
...

show more ...

Fix notices when using dw CLI

On the commandline several global variables might not be set. Accessing
them might generate an E_NOTICE.

adjusted the Input clases for PSR2

They are now in their own namespace.

Merge branch 'master' into psr2

�� Better deprecation annotation for DOKU_TPL*

This syntax can be used by IDEA and other IDEs to mark the constants as
deprecated in the editor.

Merge branch 'master' into psr2

* master:
�� (Draft) Fix exception when actually viewing a draft of a page
��(Draft): Add doc block for constructor
✅ Add unittest for deleteUsers remote API ca

Merge branch 'master' into psr2

* master:
�� (Draft) Fix exception when actually viewing a draft of a page
��(Draft): Add doc block for constructor
✅ Add unittest for deleteUsers remote API call
fix remote API call dokuwiki.deleteUsers
translation update
�� Use json for the response to dw_locktimer
✨(dw_locktimer) plugins may reuse to add fields and callbacks
�� (editor) draft status is semantically not part of the toolbar
�� Create new Draft class and move draft handling there
translation update
correctly avoid notice in init.
avoid creating expensive stacktrace in dbg_deprecated()
add method to EventHandler to check if an event is actually handled
introduce INFO_DEPRECATION_LOG event

show more ...

correctly avoid notice in init.

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.