Refactor deprecation logging into its own class

This gives us the flexibility to handle both deprecated properties and
methods/functions properly.

Use deprecation helper

Instead of writing our own magic getters and setters for all variables
that used to be public, this adds a trait that does that in a generic
way.
This trait was copied from Me

Use deprecation helper

Instead of writing our own magic getters and setters for all variables
that used to be public, this adds a trait that does that in a generic
way.
This trait was copied from MediaWiki and adjusted to DokuWiki.
The original author seems to be @tgr Tisza Gergő

The downside of this trait is that the properties keep their
(potentially undesired) name. While that could be fixed within the
helper, that might add unnecessary complexity. The name can change when
support is dropped.

show more ...

Merge branch 'master' into psr2

add logic if the server uses unlimited memory, memory_limit = -1

�� Add guard for getVersion fallback

This protects against the current commit being packed and not available
as an object and against zlib not being available.

More information about commits being

�� Add guard for getVersion fallback

This protects against the current commit being packed and not available
as an object and against zlib not being available.

More information about commits being packed and thus not available can
be found here: https://git-scm.com/book/en/v2/Git-Internals-Packfiles

show more ...

✏️ Fix typo in variable name

�� Add fallback if we cannot use git on the shell

Under some circumstances, there may be no git or no shell access available. This gets the commit
date manually.

�� make getVersion show the commit date, not checkout date

Currently, getVersion() shows the date when the HEAD of the local git
repository was last changed, not the date of the current commit. This

�� make getVersion show the commit date, not checkout date

Currently, getVersion() shows the date when the HEAD of the local git
repository was last changed, not the date of the current commit. This
commit fixes that behavior.

show more ...

Merge branch 'master' into psr2

* master:
�� (Draft) Fix exception when actually viewing a draft of a page
��(Draft): Add doc block for constructor
✅ Add unittest for deleteUsers remote API ca

Merge branch 'master' into psr2

* master:
�� (Draft) Fix exception when actually viewing a draft of a page
��(Draft): Add doc block for constructor
✅ Add unittest for deleteUsers remote API call
fix remote API call dokuwiki.deleteUsers
translation update
�� Use json for the response to dw_locktimer
✨(dw_locktimer) plugins may reuse to add fields and callbacks
�� (editor) draft status is semantically not part of the toolbar
�� Create new Draft class and move draft handling there
translation update
correctly avoid notice in init.
avoid creating expensive stacktrace in dbg_deprecated()
add method to EventHandler to check if an event is actually handled
introduce INFO_DEPRECATION_LOG event

show more ...

avoid creating expensive stacktrace in dbg_deprecated()

now the method is aborting early again unless the data is actually used

introduce INFO_DEPRECATION_LOG event

This adds an event to dbg_deprecated(). This allows plugins to handle
deprecation warnings. One example would be @cosmocode/dokuwiki-plugin-sentry

One thing I d

introduce INFO_DEPRECATION_LOG event

This adds an event to dbg_deprecated(). This allows plugins to handle
deprecation warnings. One example would be @cosmocode/dokuwiki-plugin-sentry

One thing I don't like, but don't know how to avaoid is that this
function used to abort super early when $conf['allowdebug'] wasn't set.

However for the sentry plugin you probably would want logs, but still do
not show any debugging to end users (which allow debug would do).

So now the backtrace is always built, the event triggered and then
everything is sent to dbglog() which may simply throw everything away.

Suggestions on how to improve this welcome.

show more ...

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

remove DOKU_INC checks

There is no need for this check, since these files should not have any
main code that is executed on direct call.

Fixes PSR1.Files.SideEffects.FoundWithSymbols

Update check supports HTTPS

If SSL is not supported, a HTTP request will be made. In the log the request type will be indicated, but on the frontend no additional message would be shown (I think it'

Update check supports HTTPS

If SSL is not supported, a HTTP request will be made. In the log the request type will be indicated, but on the frontend no additional message would be shown (I think it's better to notify admins about non-SSL situations, but currently when this fetch encounter error, no error message will be shown, so it's better not to add any warning).

show more ...

I supplemented the existing comments on the methods in which there was not enough information to the standard phpDoc.

increase minimum version requirement to PHP 5.6

Check the server has a sensible time

DokuWiki assumes that the server's time is correct. Especially page
revisions and cache handling depend on correct time. If that's not the
case it can lead to pr

Check the server has a sensible time

DokuWiki assumes that the server's time is correct. Especially page
revisions and cache handling depend on correct time. If that's not the
case it can lead to problems later (as mentioned in #1644).

This patch adds a very simple time check using the Date response header
from the DokuWiki server to our do=check mechanism.

show more ...

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PH

Remove error supression for file_exists()

In an older version of PHP a file_exists() call would issue a warning
when the file did not exist. This was fixed in later PHP releases. Since
we require PHP 5.3 now, there's no need to supress any error here
anymore. This might even give a minor performance boost.

show more ...

Merge remote-tracking branch 'origin/master' into scrutinizerissues

Conflicts:
inc/media.php
inc/plugin.php
inc/template.php
lib/plugins/authplain/_test/escaping.test.php
lib/plugins/syntax.php

new PHP minimum requirement is now 5.3.3

that's the version in Debian old stable

use its own cache file per versions

this ensures there will be never, ever an outdated update message shown
after upgrade.

Fix for update messages never completely going away

The existing logic for messages.txt requires some valid update
response (ending in %) to the messages update check before it clears
the current me

Fix for update messages never completely going away

The existing logic for messages.txt requires some valid update
response (ending in %) to the messages update check before it clears
the current messages.

However update.dokuwiki.org appears to return an empty string response
if everything is up to date. (ie http://update.dokuwiki.org/check/46.1 )

As a result if there are update messages in messages.txt they don't
automatically go away after updating to the current version. The only
time they change is when a newer release comes out. The upgrade plugin
has logic in it to force a re-download of messages.txt, but currently
this just re-downloads the old update messages.

This change explicitly allows for "" as a valid "no messages"
indicator (distinct from false, which is the HTTP error indicator.)

show more ...

more scrutinizer issue improvements

sanity check update message

This should avoid problems when a WiFi login redirect intercepts the
update check.
See https://forum.dokuwiki.org/post/45076

Merge pull request #693 from splitbrain/logdeprecated

log deprecated function calls FS#2399