Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to in

Functions renamed with "intl" prefix

Better naming of functions to help future maintenance.
- compare() renamed to intl_strcmp()
- sort_pagenames() renamed to intl_sort()
- sort_keys() renamed to intl_ksort()
- new function intl_asort()
- sort_filenames() renamed to intl_asortFN()
Updated documentation.

show more ...

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is us

Cleanup of function compare() [name changed]

Name changed from strcompare() to compare().

Fix of ft_pagesorter() function in "fulltext.php".
ft_pagesorter() is used by _ft_pageLookup(), which is used by ft_pageLookup().

Functions that call ft_pageLookup() and now have the expected results:
Action\Search.php:69, execute(): run the search
Ajax.php:50, callQsearch(): Searches for matching pagenames
Ajax.php:352, callLinkwiz(): List matching namespaces and pages for the link wizard

Screens fixed:
- Search (list of matching pagenames)
- Quick search (when typing)
- Internal link suggestion when editing a page (when nothing was typed)

Fix of menuSort() function in "Ui/Admin.php".

Screens fixed:
- Administration

Fix of sort_search_fulltext() function in "search.php".
This function does not seem to be used anywhere.

show more ...

Reimplementation of strcasecmp()

Reimplementation of strcasecmp() using collator.
It uses the same implementation already made for strcmp().
Fix of menuSort() function in "Ui/Admin.php".

Screens fi

Reimplementation of strcasecmp()

Reimplementation of strcasecmp() using collator.
It uses the same implementation already made for strcmp().
Fix of menuSort() function in "Ui/Admin.php".

Screens fixed:
- Administration

show more ...

Reimplementation of ksort()

Reimplementation of ksort() using collator.
Fix of getAdditionalNamespacesFromResults() function in "Ui/Search.php".

Screens fixed:
- Search (namespace selector below se

Reimplementation of ksort()

Reimplementation of ksort() using collator.
Fix of getAdditionalNamespacesFromResults() function in "Ui/Search.php".

Screens fixed:
- Search (namespace selector below search field)

show more ...

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

deprecated trigger_event() in favor of a static method on Event

First go at moving the plugin classes into their own namespace

PSR2 style fixes

These are some simple whitespace/arrangement things that apparantly
can't be fixed automatically

use utf8_strtolower instead of strtolower

compare cleaned pageid case-insensitive in search, fixes #2613

add event to check access to admin plugins

This adds a new method that capsulates the access check that has to be
done to decide if an admin plugin's page should be shown to the user.
The default im

add event to check access to admin plugins

This adds a new method that capsulates the access check that has to be
done to decide if an admin plugin's page should be shown to the user.
The default implementation is the same as before, relying only on the
forAdminOnly() method and the users' isadmin or ismanager status.

Admin plugins themselves can override the method to do additional
checks. In this patch, I added that to the usermanager plugin which will
only return true if the current auth backend can list users.

However the real idea behind this change is that the new method emits a
new event called ADMINPLUGIN_ACCESS_CHECK which would allow plugins to
overwrite it. This way it could be possible to give certain user groups
access to certain admin plugins without giving them admin or manager
permissions.

Note: this does not change how the "Admin" link is shown, it still
depends on ismanager or isadmin. A plugin as mentioned above would need
to influence the display via the MENU_ITEMS_ASSEMBLY event.

Note: this only covers the basic access check. Admin plugins may need
further adjustments for access to other parts of the plugin (like AJAX
components). An additional commit will update this for the bundled
plugins.

show more ...

line lengths shortened

This makes sure all files use line lenghts shorter than 120 characters.

This is a quick fix. It might not always be the nicest change.

feat: improve search as a primary means to create new pages

Specifically, this pull request checks if the current query is already a
valid pageid and then return that as suggested pageid.

Also, tes

feat: improve search as a primary means to create new pages

Specifically, this pull request checks if the current query is already a
valid pageid and then return that as suggested pageid.

Also, tests are added for this method.

Fixes #2355

PS: We may want to somehow better educate/nudge users to use the better
way of creating pages by creating links on existing pages.

show more ...

fix(search): don't start result position with 2

Also, for consistency this initializes also $num with 0, while ensuring
that the first FT_SNIPPET_NUMBER results with a $cnt>0 have a snippet.

refactor(search): clearer data flow

Change spacing in search meta data to punctuation

Punctuation is more natural, makes sense with CSS switched off
and makes screenreaders add a little pause.

Fix(search): restore valid heading hierarchy

In #2286 the 2nd level heading in the intro was removed, so the h3
should be promoted to h2.

fix(search): add position to fulltext results event

fix(search): ensure consistent html in search results

This implements some of the changes discussed in #2314:

1. last mod and number of hits are on the same line and always shown
2. There is a clas

fix(search): ensure consistent html in search results

This implements some of the changes discussed in #2314:

1. last mod and number of hits are on the same line and always shown
2. There is a class around the last mod string so it can be
hidden/replaced by an icon
3. All items in the resultBody returned by the event are wrapped in
`<dd>` tags to ensure validity. They get their array key as class
4. There is still a wrapper div around each result for styling purposes

show more ...

Fix invalid HTML in search results

Recent changes to the search results page added various divs
to the pre-existing description list, which is invalid.
This fixes that by a) removing a couple of unn

Fix invalid HTML in search results

Recent changes to the search results page added various divs
to the pre-existing description list, which is invalid.
This fixes that by a) removing a couple of unnecessary elements
and b) interpret the 'last modified' line as another 'dd'.

show more ...

Fix links with invalid empty target attributes

The advanced search options list links with an invalid empty target
attribute. This fixes that by skipping empty parameters.

fix: bring back the namespace in brace for pagelookup results

This was unintentionally removed in
4eab6f7c40ab5e2fbbb5e0efb20d930d4b1730fe

It also should now be clearer what the code does.

This fi

fix: bring back the namespace in brace for pagelookup results

This was unintentionally removed in
4eab6f7c40ab5e2fbbb5e0efb20d930d4b1730fe

It also should now be clearer what the code does.

This fixes #2305

show more ...

refactor: rename dta and dtb parameters

They are now named min and max respectively, which is hopefully less
cryptic.

doc(search): parameter must be string or false

doc(search): highlight is expected to be an array