fix line length issue

Add JSON based alternative to XMLRPC

XMLRPC is a rather outdated and old-fashioned protocol not much in use
anymore. Developers prefer simpler, JSON based APIs.

This adds a new "JSONRPC" API. Basic

Add JSON based alternative to XMLRPC

XMLRPC is a rather outdated and old-fashioned protocol not much in use
anymore. Developers prefer simpler, JSON based APIs.

This adds a new "JSONRPC" API. Basically it exposes exactly the same
method calls as the XMLRPC API but using JSON instead of XML. It's not a
classical REST API, but should be just as easy to use for developers.

Here is an example call using CURL:

curl http://localhost/dokuwiki/lib/exe/jsonrpc.phs \
-H 'Content-Type: application/json' \
-H "Authorization: Bearer $token" \
-d '["wiki"]'

Please note that the above uses the token auth implemented in #2432.
Authentication via basic auth or cookies would work as well.

show more ...

Update core code to make use of sexplode()

This makes use of our own explode mechanism everywhere were we expect a
fixed number of results.

increased API version

throw exceptions in API on user creation errors

As discussed in #3609

CORS on XMLRMPC API

This allows setting a CORS header to make the xmlrpc API accessible from
JavaScript clients directly in the browser.

abort XMLRPC later in serve()

Fix #3619 and correctly handle exceptions in XMLRPC

This ensures that any exception happening during XMLRPC processing is
signalled correctly to the client as XML encoded error message.

revert to simple boolean result when creating user, phpcs fix

Reverted change

fix annotation

Create one user per request

Implements #3606: add xmlrpc createUsers function

Method names with leading double underscore are reserved by PHP.

move IXR XML RPC to composer dependency #1970

This is a monky patched version of kissyfrot/php-ixr until my PR has
been accepted upstream.

Plugins using the XML RPC client may need adjustments.

fix method handling for RPC_CALL_ADD

This event seems not to be used by any plugin, which explains why this
bug hasn't surfaced yet. Access is always checked against a full method
name in the form o

fix method handling for RPC_CALL_ADD

This event seems not to be used by any plugin, which explains why this
bug hasn't surfaced yet. Access is always checked against a full method
name in the form of plugin.<pluginname>.<method> Such a full method was
not passed when using an event as described in the documentation.

show more ...

Fix various errors in PHPUnit tests on PHP 8

wrap sorting functions into their own class

Page sort added in listPages()

getPagelist(), getAttachments() and getBackLinks() provided sorted results, but listPages() did not.
[bug fix] Added missing 'doc' keys in lines 145 and 149.

fallback to auth_login check when trustExternal returns null

This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is

fallback to auth_login check when trustExternal returns null

This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is used in auth_login()). I believe we should provide plugin developers with a third state as out-put. Semantically $auth->trustExternal() === null to delegate auth flow back to DokuWiki makes sense to me - like no external auth result is returned, so we need to run internal auth flow.

Co-Authored-By: paweljasinski <paweljasinski@users.noreply.github.com>

show more ...

add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions

add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions if it's about argument
missing.

show more ...

catch ArgumentCountError and return XML error message for remoteAPI, fixes #2545

This is caused by a PHP 7.1 change:
https://www.php.net/manual/en/migration71.incompatible.php
#migration71.incompati

catch ArgumentCountError and return XML error message for remoteAPI, fixes #2545

This is caused by a PHP 7.1 change:
https://www.php.net/manual/en/migration71.incompatible.php
#migration71.incompatible.too-few-arguments-exception

Previously call_user_func_array will make those missing arguments
to NULL without throwing an exception.

show more ...

set default argument value for some of remote methods

most are array params and one int. Note that before if they were not present
from the remote request, a null will be applied to the argument, so

set default argument value for some of remote methods

most are array params and one int. Note that before if they were not present
from the remote request, a null will be applied to the argument, so this is
actually applying the correct data type on the arguments.

show more ...

PHP8 fix part 1: Trying to access array offset on value of type bool/null

Add failing unit test for #2883