API: clean up error codes

Error codes are now extracted from API core and printed on the OpenAPI
overview page. This makes it easier to see what is in use.

Error messages have been cleaned up, some

API: clean up error codes

Error codes are now extracted from API core and printed on the OpenAPI
overview page. This makes it easier to see what is in use.

Error messages have been cleaned up, some new codes have been assigned.

Some errors have been removed. Eg. it is fine to iterate a media
namespace you don't have read access to. The result will either be empty
or contain files from lower namespaces that you *do* have access to.

show more ...

API: Do not assume the start page for empty pageIDs

API: move create/delete user calls to usermanager

This only moves the calls. A proper refactoring of the user manager
would make sense:

1) introduce a helper component covering the basic operations

API: move create/delete user calls to usermanager

This only moves the calls. A proper refactoring of the user manager
would make sense:

1) introduce a helper component covering the basic operations including
proper error signalling using Exceptions
2) refactor admin and cli components to make use of 1)
3) make the operations in 1) available via the API

show more ...

Reworked API definition

This cleans up the API:

* no more compatibility with obsolete wiki API
* no more difference between wiki.* and dokuwiki.* calls -> core.*
* use of optional parameters avoids

Reworked API definition

This cleans up the API:

* no more compatibility with obsolete wiki API
* no more difference between wiki.* and dokuwiki.* calls -> core.*
* use of optional parameters avoids double definitions
* use Response objects for complex results
* always use named primitives as input
* major cleanup of docblock descriptions

show more ...

OpenAPI Gen: handle Object to Schema transformation correctly

All the basic mechanisms should now be in place to clean up the API

OpenAPI Generator. Better DocBlock parsing [WIP]

This introduces a new DocBlock parser to properly generate API
specifications. It also introduces the concept of Response classes to
better specify t

OpenAPI Generator. Better DocBlock parsing [WIP]

This introduces a new DocBlock parser to properly generate API
specifications. It also introduces the concept of Response classes to
better specify the response format.

This is still very much in progress.

show more ...

improved API docs

rename $id to be more clear

It should be more clear if a media or page ID is passed. Also
openapi-explorer will not prefill examples for any parameters called
*id*.

improve the doc blocks in ApiCore

Do not directly use native function in API

As fedb87702391d74284af4d0c0add4330d3456195 showed, we can not directly
use native fuctions because they have no proper type hinting in PHP7.4

final set of API tests refactored

another set of api tests

First go at refactoring the API mechanisms

This introduces an ApiCall class that wraps around the actual method
that produces the result. This replaces various loose array structures
that provided t

First go at refactoring the API mechanisms

This introduces an ApiCall class that wraps around the actual method
that produces the result. This replaces various loose array structures
that provided the meta information before.

The ApiCall streamlines the aggregation of meta information between core
and plugin methods. Now all data is produced by Reflection based
introspection. Certain aspects can be overridden if needed. See
ApiCore::getRemoteInfo() for examples

This change removes the _getMethods() method from remote plugins and
introduces a getMethods() method. The two are NOT compatible as the
latter now returns a list of ApiCalls. However when looking at the
existing plugins, it seems that _getMethods() was nearly 100% obsolete
with the Reflection based default implementation. So most plugins will
not be affected at all. Some might now export one or two more methods
than before because of poor visibility settings (eg. not declaring
private/protected methods as such).

This change removes the RPC_CALL_ADD hook. Only a single plugin ever
implemented it. I'm not sure what this hook was supposed to do anyway.
Being able to declare arbitrarily named API endpoints seems wrong to me
anyway.

The new ApiCall now also supports passing named instead of positional
parameters. This will open up a new opportunity to get a proper openapi
spec running.

Next step is fixing the tests.

show more ...

�� Rector and PHPCS fixes

use $auth instanceof AuthPlugin instead of not null check

apply PSR-12 constant visibility rule

PSR-12 says constants need their visibility declared from PHP 7.1
onwards

Apply rector fixes to inc/Remote

increased API version

throw exceptions in API on user creation errors

As discussed in #3609

revert to simple boolean result when creating user, phpcs fix

fix annotation

Create one user per request

Implements #3606: add xmlrpc createUsers function

Merge remote-tracking branch 'upstream/master' into Refactor_Fulltext

Method names with leading double underscore are reserved by PHP.