Do not directly use native function in API

As fedb87702391d74284af4d0c0add4330d3456195 showed, we can not directly
use native fuctions because they have no proper type hinting in PHP7.4

final set of API tests refactored

another set of api tests

First go at refactoring the API mechanisms

This introduces an ApiCall class that wraps around the actual method
that produces the result. This replaces various loose array structures
that provided t

First go at refactoring the API mechanisms

This introduces an ApiCall class that wraps around the actual method
that produces the result. This replaces various loose array structures
that provided the meta information before.

The ApiCall streamlines the aggregation of meta information between core
and plugin methods. Now all data is produced by Reflection based
introspection. Certain aspects can be overridden if needed. See
ApiCore::getRemoteInfo() for examples

This change removes the _getMethods() method from remote plugins and
introduces a getMethods() method. The two are NOT compatible as the
latter now returns a list of ApiCalls. However when looking at the
existing plugins, it seems that _getMethods() was nearly 100% obsolete
with the Reflection based default implementation. So most plugins will
not be affected at all. Some might now export one or two more methods
than before because of poor visibility settings (eg. not declaring
private/protected methods as such).

This change removes the RPC_CALL_ADD hook. Only a single plugin ever
implemented it. I'm not sure what this hook was supposed to do anyway.
Being able to declare arbitrarily named API endpoints seems wrong to me
anyway.

The new ApiCall now also supports passing named instead of positional
parameters. This will open up a new opportunity to get a proper openapi
spec running.

Next step is fixing the tests.

show more ...

�� Rector and PHPCS fixes

use $auth instanceof AuthPlugin instead of not null check

apply PSR-12 constant visibility rule

PSR-12 says constants need their visibility declared from PHP 7.1
onwards

Apply rector fixes to inc/Remote

increased API version

throw exceptions in API on user creation errors

As discussed in #3609

revert to simple boolean result when creating user, phpcs fix

fix annotation

Create one user per request

Implements #3606: add xmlrpc createUsers function

Method names with leading double underscore are reserved by PHP.

Merge pull request #3115 from moisesbr-dw/sort-with-collator

Sort with collator

wrap sorting functions into their own class

Page sort added in listPages()

getPagelist(), getAttachments() and getBackLinks() provided sorted results, but listPages() did not.
[bug fix] Added missing 'doc' keys in lines 145 and 149.

Merge pull request #3006 from splitbrain/auth-external-fallback

fallback to auth_login check when trustExternal returns null

fallback to auth_login check when trustExternal returns null

This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is

fallback to auth_login check when trustExternal returns null

This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is used in auth_login()). I believe we should provide plugin developers with a third state as out-put. Semantically $auth->trustExternal() === null to delegate auth flow back to DokuWiki makes sense to me - like no external auth result is returned, so we need to run internal auth flow.

Co-Authored-By: paweljasinski <paweljasinski@users.noreply.github.com>

show more ...

set default argument value for some of remote methods

most are array params and one int. Note that before if they were not present
from the remote request, a null will be applied to the argument, so

set default argument value for some of remote methods

most are array params and one int. Note that before if they were not present
from the remote request, a null will be applied to the argument, so this is
actually applying the correct data type on the arguments.

show more ...

PHP8 fix part 1: Trying to access array offset on value of type bool/null

fix type hints

thos broke during refactoring

deprecated trigger_event() in favor of a static method on Event

First go at moving the plugin classes into their own namespace