codestyle adjustments: function declaration braces/spaces

codestyle adjustments: class declaration braces

Apply rector renames

apply PSR-12 constant visibility rule

PSR-12 says constants need their visibility declared from PHP 7.1
onwards

fix overlong line introduced by rector

Apply rector fixes to inc/Extension and inc/Debug

Add method to access all currently registered event handlers

Update core code to make use of sexplode()

This makes use of our own explode mechanism everywhere were we expect a
fixed number of results.

Fix Undefined array key "fperm" warning

Also removed a few, now unnecessary `!empty` checks

Fixes #3382

central logging mechanism

This introduces a logger mechanism and a new data/log directory. This is
a first proof of concept. It's built on top of the new global error
handling mechanism

Things to d

central logging mechanism

This introduces a logger mechanism and a new data/log directory. This is
a first proof of concept. It's built on top of the new global error
handling mechanism

Things to discuss:

* should we adopt PSR-3 somehow? if yes, how and should plugins be able
to drop-in other psr3 loggers?
* how to configure which facilities shall be logged?
* should we implement a log deletion feature?
* is the log format sensible?
* should we implement a log viewer admin plugin?
* should logging trigger events (it should maybe replace the
deprecation event)

show more ...

reflow overlong line

better exception handling on plugin loading

Now all important places where plugins are loaded are guarded by a
try/except. We're catching Throwables here to be able to catch stuff
like syntax errors

better exception handling on plugin loading

Now all important places where plugins are loaded are guarded by a
try/except. We're catching Throwables here to be able to catch stuff
like syntax errors early on (otherwise they will only be caught by our
ErrorConverter much too late). This means that this change requires PHP
7.0 minimum!

show more ...

introduce a global error handler

This transfers old style PHP errors into Exceptions and installs a
global exception handler. All exceptions caught by this handler are
logged to an error log and a m

introduce a global error handler

This transfers old style PHP errors into Exceptions and installs a
global exception handler. All exceptions caught by this handler are
logged to an error log and a meassage is shown to the end user. This
should finally get rid of "blank page" bug reports.

show more ...

fallback to auth_login check when trustExternal returns null

This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is

fallback to auth_login check when trustExternal returns null

This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is used in auth_login()). I believe we should provide plugin developers with a third state as out-put. Semantically $auth->trustExternal() === null to delegate auth flow back to DokuWiki makes sense to me - like no external auth result is returned, so we need to run internal auth flow.

Co-Authored-By: paweljasinski <paweljasinski@users.noreply.github.com>

show more ...

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures all possible ways to define a callback (including static
methods) can be used.

This should fix a problem mentioned in #2943

show more ...

Check code style against PSR12

In 2019 PSR-12 was officially released and PSR-2 deprecated. We should
adapt to that and check our files against that new coding standard.

some more PSR2 cleanup

mostly overlong lines and more exclude patterns

Minor optimizations in PluginController

Snake to Camel case fixes inn PluginController

Fix snake->camel case, doc blocks

For compatibility reasons, the methods have not been renamed.

minor code simplification

snake to camel case fixes in EventHandler

For compatibility reasons with basically all existing plugins, the
methods have not been renamed. Instead the appropriate check is ignored.

Move list of plugin types to plugin controller constant

There is no need to have them in a global variable.

Avoid processing events before the Event System is intiialized

isEnabled instead of isDisabled

Boolean Methods with a negative name are a bit confusing. Getting false
for an enabled plugin? Better check for Enabled status.