Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime, media and link output in xhtml renderer is adjusted, to show title text instead when src/href is null. In interwiki case, the title will be the "reference" part of the interwiki link.

This makes it possible to also support no URL cases in `interwiki.conf`. Before it will output a URL as `rawurlencode($reference)`, which doesn't make too much sense since it's encoded. However, I am not sure the use case under the current behavior (no URL, but text as `$reference`).

Docs needs to be added to warn renderer plugin developers of this situation.

This fixes #2588.

show more ...

css_compress: quote placeholder to simply quote protection

There are two ways of doing this:

1. "doku" > STR1 > "doku"
2. "doku" > "1" > "doku"

#1 is what I did before. I did replace STRN with a n

css_compress: quote placeholder to simply quote protection

There are two ways of doing this:

1. "doku" > STR1 > "doku"
2. "doku" > "1" > "doku"

#1 is what I did before. I did replace STRN with a new placeholder in the previous implementation so that there is no conflict. However #2 is more elegant, so this commit implements it.

Test is updated to address splitbrain's concern about placeholder string in the original text.

show more ...

add quotes test for #2517

Add failing unit test for #2883

added group internet to html validity checks

Because we use an online validator

Avoid flaky tests by waiting full seconds

The waitForTick() method tried to be clever and return early if a second
had passed since the last call already. Unfortunatel this did not work
reliably in

Avoid flaky tests by waiting full seconds

The waitForTick() method tried to be clever and return early if a second
had passed since the last call already. Unfortunatel this did not work
reliably in our tests and we often had failures on tests that required
unique revision numbers.

Pull requests for a reliable version welcome. Until the we wait a second
on each call.

show more ...

lock fetch PHPUnit version to 7 for PHP5

use a script to fetch the correct phpunit

We should replace this with a composer dev dependency some time.

There's still a failing mysql test. Gotta figure out what's happening
there. But at least

use a script to fetch the correct phpunit

We should replace this with a composer dev dependency some time.

There's still a failing mysql test. Gotta figure out what's happening
there. But at least the tests work at all again

show more ...

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

some more PSR2 cleanup

mostly overlong lines and more exclude patterns

Some cleanup for the UTF-8 stuff

Docblocks, imports, etc...

Ignore mixed concerns in loader

We define and register the autoloader here.

adjust phpcs exclude patterns for new plugin classes

We still need to ignore a bunch of stuff for backwardscompatibility

fix and test php_to_byte() related to #2756 #2556

This refactors the php_to_byte() method to properly return integers
always. A bug when reading byte sizes under 10 bytes was fixed. Infinity
(signal

fix and test php_to_byte() related to #2756 #2556

This refactors the php_to_byte() method to properly return integers
always. A bug when reading byte sizes under 10 bytes was fixed. Infinity
(signaled by a -1 in php.ini) is now returned as -1.

According to [1] PHP supports size shortcuts for (K)ilobytes,
(M)egabytes and (G)igagbytes only. The support for Tera- and Petabytes
has been removed.

[1] https://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes

show more ...

♻️ Split up ChangesSubscriptionSender into multiple classes

This should better adhere to SRP and simplify things.

Automatic code style fixes for subscription classes

✅ Fix Subscriptions tests

This splits up and slightly refactors the tests for the refactored subscriptions classes

moved plugin controller to Extension namespace

deprecated trigger_event() in favor of a static method on Event

First go at moving the plugin classes into their own namespace

Rename HTTPClient namespace to HTTP

This should make namespace a bit more flexible in scope and allow us to
move more functionality there later.

Rename protected methods for PSR2

Refactor HTTPClient into different files

add ID/NS = '0' test against page_findnearest

add key/value = '0' test to metadata indexer