Change cases of assertTrue in tests

add drupal and seafile hash methods

Add test for video titles

add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions

add alternative support for PHP not throwing ArgumentCountError in remote/APi

PHP 5.6 and 7.0 won't throw ArgumentCountError. In this case, we use
set_error_handler on E_WARNING and throw exceptions if it's about argument
missing.

show more ...

suppress argument missing warnings on remote API test

This makes sure PHPUnit won't convert warnings into exceptions, and thus behaves
as the same as regular DokuWiki where E_NOTICE is suppressed.

rename vague AuthPlugin used by remote and authdelete tests

add unit tests that check exception type on remote args missing for #2545

relax Revert permission to EDIT from manager

Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check.

Than

relax Revert permission to EDIT from manager

Revert is another type of edit, which may be simulated by manual editing without using this shortcut. This patch thus relaxes the permission check.

Thank you @Klap-in for pointing this out.

show more ...

Split out temporary code style excludes

Splitting them out allows for plugins to use _test/phpcs.xml as the
basis for their own linting without having an overly permissive coding
standard.
Also, thi

Split out temporary code style excludes

Splitting them out allows for plugins to use _test/phpcs.xml as the
basis for their own linting without having an overly permissive coding
standard.
Also, this makes it more obvious and painful that these are just
intended as temporary exceptions and should be actually fixed.

The rule `Generic.ControlStructures.InlineControlStructure.NotAllowed`
has its comment adjust to make it clear that this is an intended
deviation from the PSR-2/PSR-12 coding standard.

The rule `PSR1.Classes.ClassDeclaration.MissingNamespace` has to remain
in the DokuWiki coding standard as the plugin base classes can currently
not reasonably be in namespaces.

show more ...

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures

Better callable support in Event default actions

Instead of parsing the passed callback ourselves, this patch relies on
call_user_func_array() instead to call an Event's default action. This
ensures all possible ways to define a callback (including static
methods) can be used.

This should fix a problem mentioned in #2943

show more ...

create PluginUtils.test.php

add trim, and polish test_quotes of css_compress, again

An edge case that space at the beginning won't get removed.

polish test_quotes of css_compress

Now the testcase string should be clearer to read

Add test_escapedQuotes to css_compress

Thank you @micgro42!

Co-Authored-By: Michael Große <mic.grosse@googlemail.com>

Check code style against PSR12

In 2019 PSR-12 was officially released and PSR-2 deprecated. We should
adapt to that and check our files against that new coding standard.

Extract dokuwiki\Search\Indexer class

Not sure why Doku_Indexer caused phpcs to complain about the class name
not being in PascalCase, but Doku_Handler didn't. ��

The namespace and new class name w

Extract dokuwiki\Search\Indexer class

Not sure why Doku_Indexer caused phpcs to complain about the class name
not being in PascalCase, but Doku_Handler didn't. ��

The namespace and new class name was selected to be compatible with the
upcoming changes in #2943. This should hpopefully reduce the overall
hassle of touching the same code base.

show more ...

Ignore some more definitions

Some of the files are still having both logic and side-effects for
legacy reasons. We are excluding them for now and might deal with them
later.

Check our code style for every PR

This excludes the currently failing checks with automatic fixes, as they
are out of scope of this commit. The current goal is automatically
reject pull requests tha

Check our code style for every PR

This excludes the currently failing checks with automatic fixes, as they
are out of scope of this commit. The current goal is automatically
reject pull requests that don't me the standards that the rest of our
code base already follows.

show more ...

PHP8 fix part 5: Trying to access array offset on value of type bool/null

Ignore certain HTML validity errors

We use the ugc (user generated content) value for no-follow links since #2855
this is not yet supported in the validator.

This patch introduces a list of ignored

Ignore certain HTML validity errors

We use the ugc (user generated content) value for no-follow links since #2855
this is not yet supported in the validator.

This patch introduces a list of ignored error messages.

show more ...

Fix curly brace deprecations in _test/ directory.

clientIP: modify test to assume trusted proxy be included in IP array

clientIP: Add tests addressing #2828

We cannot trust any IP not included in $conf['trustedproxy'].

getGoogleQuery: add tests

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed a problem that Scrutinizer complained about.

show more ...