avoid dependency tests being marked as risky

use dataprovider in password tests

This fixes a problem with those tests in the most recent version of
phpunit. I thought it was caused by the use of the deprecated var
keyword, but some other weird

use dataprovider in password tests

This fixes a problem with those tests in the most recent version of
phpunit. I thought it was caused by the use of the deprecated var
keyword, but some other weirdness was going on. This way it's more
proper anyway.

show more ...

replace some var keywords

This should fix some tests on PHP 7.1. The work is far from done, we
still have a lot of variables without proper accessibility defined.

no longer rely on actionOk when checking if actions are disabled

loadAction() and checkAction() are now public and could be used within
actionOK(). However some weird circular references prevent tha

no longer rely on actionOk when checking if actions are disabled

loadAction() and checkAction() are now public and could be used within
actionOK(). However some weird circular references prevent that. In
addition, actionOK is also used to check for things that aren't Actions
(yet) like 'rss' and 'top'.

show more ...

allow actions to be initialized without an action name

also fixes the tests

all actions should have a class now

Lots of FIXMEs and the routing isn't integrated, yet

start of a refactoring the action routing

This is neither complete nor working, yet

mark some tests as non-risky

Those tests either just check that an exception is NOT thrown or are
there to check dependencies for other tests. Newer phpunits mark all
tests as risky that have no ass

mark some tests as non-risky

Those tests either just check that an exception is NOT thrown or are
there to check dependencies for other tests. Newer phpunits mark all
tests as risky that have no assertion.

show more ...

I will be so glad when we stop supporting old PHP

actually we could right now. but I don't like to introduce that change in
a feature branch.

make use of exception wrapper in io test

Handle breaking class rename in PHPUnit 6.0

See for reference #1837 and sebastianbergmann/phpunit#2503

PHPUnit 6 now only supports namespaced classes

However those classes are already supported in PHP 5.7 so we can switch
to them without breaking backward-compatibility.

mysql 4.11+ hash is supposed to be upper case. fixes #1825

fixed typo in function name

changed embedSVG to inlineSVG and make it return contents

This makes it more flexible to use on the expense of needing one echo
more.

more cleanup in embedSVG

now comments and line breaks between tags are removed

Add test to verify that no error occurs

Without the change in issue #1801, or commit
1b26d16d86d6a898466211861adc1dff2286da2b respectively, this adjusted
test would throw an error since it would att

Add test to verify that no error occurs

Without the change in issue #1801, or commit
1b26d16d86d6a898466211861adc1dff2286da2b respectively, this adjusted
test would throw an error since it would attempt to use another array as
an array-key.

The fact that the test passes without error means that the bug is fixed.

show more ...

Fix media changelog test that did not expect delayed changelog entry

What happened was that in the place of the new `waitForTick`-call an
actual delay happened and therefore the file modification ti

Fix media changelog test that did not expect delayed changelog entry

What happened was that in the place of the new `waitForTick`-call an
actual delay happened and therefore the file modification time and the
deletion entry were two different points in time, resulting in random
test failures. The test enforces this now, the condition to test has
been adjusted.

show more ...

Add testing of delayed writes to the remote API

Added more testing to ensure correct handling of delayed writes

refactor: handle default options w/ other optgroups

fix: ensure that there is only 1 selected option

Multiple selected option would not be valid HTML.

Add test for optgroup support in selects

use waitForTick in all our tests

refactored the remote API tests

Now each command is checked within it's own test on a completely clean
install. Hopefuly this also takes care of the flaky test behavior seen
at Travis occasionally.