Add test_escapedQuotes to css_compress

Thank you @micgro42!

Co-Authored-By: Michael Große <mic.grosse@googlemail.com>

Extract dokuwiki\Search\Indexer class

Not sure why Doku_Indexer caused phpcs to complain about the class name
not being in PascalCase, but Doku_Handler didn't. ��

The namespace and new class name w

Extract dokuwiki\Search\Indexer class

Not sure why Doku_Indexer caused phpcs to complain about the class name
not being in PascalCase, but Doku_Handler didn't. ��

The namespace and new class name was selected to be compatible with the
upcoming changes in #2943. This should hpopefully reduce the overall
hassle of touching the same code base.

show more ...

PHP8 fix part 5: Trying to access array offset on value of type bool/null

Ignore certain HTML validity errors

We use the ugc (user generated content) value for no-follow links since #2855
this is not yet supported in the validator.

This patch introduces a list of ignored

Ignore certain HTML validity errors

We use the ugc (user generated content) value for no-follow links since #2855
this is not yet supported in the validator.

This patch introduces a list of ignored error messages.

show more ...

clientIP: modify test to assume trusted proxy be included in IP array

clientIP: Add tests addressing #2828

We cannot trust any IP not included in $conf['trustedproxy'].

getGoogleQuery: add tests

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed

Add "default" keyword support for interwiki links

Thank you @selfthinker for the suggestion!

If nothing is found in default, it will still fall back to "". Test is added as well.

Meantime I fixed a problem that Scrutinizer complained about.

show more ...

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime

Remove Google Lucky for non-existing interwiki links

For compatibility renderer will return string '' of $shortcut and $url instead of NULL when seeing a non-existing interwiki link. In the meantime, media and link output in xhtml renderer is adjusted, to show title text instead when src/href is null. In interwiki case, the title will be the "reference" part of the interwiki link.

This makes it possible to also support no URL cases in `interwiki.conf`. Before it will output a URL as `rawurlencode($reference)`, which doesn't make too much sense since it's encoded. However, I am not sure the use case under the current behavior (no URL, but text as `$reference`).

Docs needs to be added to warn renderer plugin developers of this situation.

This fixes #2588.

show more ...

css_compress: quote placeholder to simply quote protection

There are two ways of doing this:

1. "doku" > STR1 > "doku"
2. "doku" > "1" > "doku"

#1 is what I did before. I did replace STRN with a n

css_compress: quote placeholder to simply quote protection

There are two ways of doing this:

1. "doku" > STR1 > "doku"
2. "doku" > "1" > "doku"

#1 is what I did before. I did replace STRN with a new placeholder in the previous implementation so that there is no conflict. However #2 is more elegant, so this commit implements it.

Test is updated to address splitbrain's concern about placeholder string in the original text.

show more ...

add quotes test for #2517

Add failing unit test for #2883

added group internet to html validity checks

Because we use an online validator

replaced deprecated utf8 functions

For now this uses full qualified namespaces, sensible imports may come
later.

fix and test php_to_byte() related to #2756 #2556

This refactors the php_to_byte() method to properly return integers
always. A bug when reading byte sizes under 10 bytes was fixed. Infinity
(signal

fix and test php_to_byte() related to #2756 #2556

This refactors the php_to_byte() method to properly return integers
always. A bug when reading byte sizes under 10 bytes was fixed. Infinity
(signaled by a -1 in php.ini) is now returned as -1.

According to [1] PHP supports size shortcuts for (K)ilobytes,
(M)egabytes and (G)igagbytes only. The support for Tera- and Petabytes
has been removed.

[1] https://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes

show more ...

♻️ Split up ChangesSubscriptionSender into multiple classes

This should better adhere to SRP and simplify things.

Automatic code style fixes for subscription classes

✅ Fix Subscriptions tests

This splits up and slightly refactors the tests for the refactored subscriptions classes

moved plugin controller to Extension namespace

deprecated trigger_event() in favor of a static method on Event

First go at moving the plugin classes into their own namespace

Rename HTTPClient namespace to HTTP

This should make namespace a bit more flexible in scope and allow us to
move more functionality there later.

Rename protected methods for PSR2

Refactor HTTPClient into different files

add ID/NS = '0' test against page_findnearest