cleaned up Doku_Handler for PSR-2

add methods to test interal properties

You shouldn't really do this. But sometimes its so much easier to write
a test that flips an internal bit than to do it poperly(tm). Better a
risky test than n

add methods to test interal properties

You shouldn't really do this. But sometimes its so much easier to write
a test that flips an internal bit than to do it poperly(tm). Better a
risky test than none...

show more ...

adjusted the Lexer for PSR-2

adjusted Doku_Parser for PSR-2

All properties are declared protected. The handler is now set via the
constructor.

split handler.php into multiple files

For now I left Doku_Handler itself as it were. We will need to keep the
class name around for backwards compatibility but should move the class
itself.

I intro

split handler.php into multiple files

For now I left Doku_Handler itself as it were. We will need to keep the
class name around for backwards compatibility but should move the class
itself.

I introduced a new ReWriter Interface to formalize how the various call
writer implementations are accessed.

There are a whole bunch of doc blocks missing.

show more ...

split out parser modes into their own files

This moves all the parser classes into their own namespace and files.
Next up are the handler classes.

I'm not sure about the namespace, yet. A nested na

split out parser modes into their own files

This moves all the parser classes into their own namespace and files.
Next up are the handler classes.

I'm not sure about the namespace, yet. A nested namepspace Parser\Modes
would probably make more sense... we'll see.

This also removes the duplicated coded in the Plugin mode. We now use
the plugin trait and can inherit from AbstractMode instead.

show more ...

visibility definition for the renderers

I made a lot of things public that probaly should be protected. But many
syntax plugins do access renderer mechanisms directly, so better stay on
the safe sid

visibility definition for the renderers

I made a lot of things public that probaly should be protected. But many
syntax plugins do access renderer mechanisms directly, so better stay on
the safe side here.

The base renderer is now abstract.

show more ...

fixed broken tests

I also introduced an auto loaded namespace for the tests.

visibility fixes

First start at declaring visibilites for methods and properties. Still
missing: the parser/renderer stuff and the plugins

adldap is a 3rd party lib

disable some sniffs on things we can not change

because backwards compatibility. There will be more excludes. This is
just a start.

do not check for namespace use, yet

We have to support lots of legacy code without namespaces

added php code sniffer config

feat: improve search as a primary means to create new pages

Specifically, this pull request checks if the current query is already a
valid pageid and then return that as suggested pageid.

Also, tes

feat: improve search as a primary means to create new pages

Specifically, this pull request checks if the current query is already a
valid pageid and then return that as suggested pageid.

Also, tests are added for this method.

Fixes #2355

PS: We may want to somehow better educate/nudge users to use the better
way of creating pages by creating links on existing pages.

show more ...

some basic framework to do at least some HTML validity checking

Checks are done against the w3.org validator API. Currently we have some
fails. One will be fixed in #2314, others still need to be fi

some basic framework to do at least some HTML validity checking

Checks are done against the w3.org validator API. Currently we have some
fails. One will be fixed in #2314, others still need to be fixed.

This integration test also reveals some code bugs because texts do not
suppress warnings and deprecation messages.

show more ...

Prevent HTML and JS injection in section names

Before this change, HTML and some JS code (as far as it was not escaped
by json_encode) could be injected into the output as the closing pattern
that i

Prevent HTML and JS injection in section names

Before this change, HTML and some JS code (as far as it was not escaped
by json_encode) could be injected into the output as the closing pattern
that is checked by the regex is not escaped in JSON (see test case).

show more ...

relax geshi options a bit more

Quotes are now optional, the options are spearated by space

make testing of inaccessible methods easier

While it's generally frowned upon testing privates, it can often be
useful and the easier way to write tests. Eg you want to test something
complicated me

make testing of inaccessible methods easier

While it's generally frowned upon testing privates, it can often be
useful and the easier way to write tests. Eg you want to test something
complicated method that is important, but you do not want to expose it
directly to other classes...

This new method uses reflection to make access to such methods possible
from within tests without the need for intermediate classes.

show more ...

renamed ActionRouter::checkPermissions to checkPreconditions

As discussed in #1933

feat: add a simple unparser for parsed search queries

To allow creating links with manipulated versions of the current search
query an unparser is necessary. However, the current output of ft_queryP

feat: add a simple unparser for parsed search queries

To allow creating links with manipulated versions of the current search
query an unparser is necessary. However, the current output of ft_queryParser
makes some advanced features hard to detect. Therefore the new
ft_queryUnparser_simple cannot handle negated phrases and `OR` searches.

It should still cover 98% of search queries.

show more ...

use expectException instead of setExpectedException for PHPUnit

remove createMock & createPartialMock polyfill, dropping support for PHPUnit 5.7-

Refactored section edit

The data for the section edit button is now passed as an assoziative array which is
encoded in the '#<!-- EDIT(.*) -->#' placeholder as an JSON array.

add tests to DifferenceEngine and optimize each removal in it

fix: prevent two selected options, b/c apparently 'String' == 0 ��

There was a bug, where the options array ['Auto', 0, 1] would result in
HTML option tags where both the 'Auto' and the 0 option we

fix: prevent two selected options, b/c apparently 'String' == 0 ��

There was a bug, where the options array ['Auto', 0, 1] would result in
HTML option tags where both the 'Auto' and the 0 option were selected.

show more ...