update unittest checkChangeLogAfterNormalSave

add routine for "save on top of external edit" assertions

saveWikiText() unittest 5

5.1 create a page
5.2 external edit
5.3 edit and save
5.4 delete
5.5 create a page, second time
5.6 externally delete
5.7 create a page, third time

saveWikiText() unittest 3.3

second to last revision check after repeated external edit

saveWikiText() unittest 4

4.1 externally create a page
4.2 edit and save
4.3 externally edit (file older than last rev)

group assertions for saveWikiText()

removed wrong test

See
https://github.com/splitbrain/dokuwiki/pull/3272#issuecomment-966367900
for reasoning

fix fallback implementation for resolve_pageid()

When an empty link was given, the old implementation fell back to $ID,
this was handled incorrectly in the deprecated method.

simplify relative resolver and add tests

make resolveStartPage easier to understand

This dosn't really change the behaviour but makes the code easier to
grasp. A simple unit test has been added.

Update common_saveWikiText.test.php

getRevisions() may return empty array when changelog file does not yet exist.

rewrite unit test of saveWikiText

fix typo

typo

UnitTest of pageinfo(), saveWikiText()

ChangeLog creates early .change file, p_get_metadata() will get full "meta_last_change" entry. The current key in the revinfo need to be excluded prior to p_s

UnitTest of pageinfo(), saveWikiText()

ChangeLog creates early .change file, p_get_metadata() will get full "meta_last_change" entry. The current key in the revinfo need to be excluded prior to p_set_metadata() call.

show more ...

UnitTest, ApiCore::pageInfo()

author is available from changelog::getRevisionInfo()

UnitTest around changelog, set correct time of page source

ChangeLog constructor will check the date of current page/media file to detect external edits via getCurrentRevisionInfo()

Remove phpunit cache.

Fix PHPUnit fatal errors compatibility with void.

Method names with leading double underscore are reserved by PHP.

move IXR XML RPC to composer dependency #1970

This is a monky patched version of kissyfrot/php-ixr until my PR has
been accepted upstream.

Plugins using the XML RPC client may need adjustments.

:fire: fix the calculation of file permissons

Our config allows to set the values for `dmode` and `fmode` to allow
users to explicitly define which permissions directories and files
should have.

To

:fire: fix the calculation of file permissons

Our config allows to set the values for `dmode` and `fmode` to allow
users to explicitly define which permissions directories and files
should have.

To avoid unnessary chmod operations, we check the current umask to
compare what permissions files and directories would get witout our
intervention. If the result is already what the user wants, no chmods
will happen later on. Otherwise we set new configs called `dperm` and
`fperm` which will be used in chmod ops. This is done in
`init_creationmodes()`

When we created new directories, we used to pass the original `dmode`
config to `mkdir()`. The system will then apply the umask to that
`dmode`.

This means the resulting directory will *always* have different
permissions than `dmode`, *always* requiring a chmod operation.
That's silly.

**Breaking Change:** This patch removes the passing of `dmode` as
second parameter to all `mkdir` calls, making it default to `0700`
which is also what we test against in `init_creationmodes()`.

Plugins not relying on our `io_*` functions and do create their own
directories and which currenlty pass `dmode` to it need to be
adjusted to remove that second parameter.

Users may want to reapply the proper file permissions to their data
folder.

**Revert:** In 9fdcc8fcd87114ca59a1764a84d213a53c655c8c @movatica
introduced a change to `init_creationmodes()` that compared the umask
against `fmode` instead of `0666`. I merged it because it looked logical
when compared to the code for directories which compared against `dmode`
as described above. However we do not pass `fmode` to any file creation
methods (that's not possible).

The result is that all changes made in the `fmode` setting resulted
in the wrong permissions for newly created files as first reported in
https://forum.dokuwiki.org/d/19463-setting-fmode-not-working-as-intended

I'm unsure about the orginal motivation behind @movatica's change. The
"fix" however, is wrong.

**Tests:** This patch introduces an integration test that will check the
actual results of directory and file creations under various umask,
`dmode` and `fmode` settings.

show more ...

Add support for SHA256 encrypted passwords

Enable detection of SHA256 hashes (prefixed with $5$) and allow to
use this hashing schemes in passwords.

add unit test for namespace exclusion in ft_pageLookup()

Add tests on sectionID and fixes #3436

This commit fixes a bug on sectionID which could lead to having duplicated id.

Note that this commit changes the API a bit $check used to be a key-value array

Add tests on sectionID and fixes #3436

This commit fixes a bug on sectionID which could lead to having duplicated id.

Note that this commit changes the API a bit $check used to be a key-value array
(with key=the origin id, and value=the number of time this id has been generated)
and is now just an array of string. That's because the previous structure
couldn't work.

As far as Dokuwiki sources are concerned, this change should have no impact because:
- most call to sectionID are done with $check=false (and the behavior in this case
isn't changed
- only Doku_Renderer->_headerToLink passes an actual array to this method. But this
array is initialized empty, it is only filled and read by sectionID itself.
(this Doku_Renderer->headers array is protected but the classes which extends it
aren't referring this array).

It could still break usages of pluging that would call sectionID and rely on the
format of this array. But even if this commits kept $check as an array<string, bool>
(for instance setting the values to 1) the semantic wouldn't be the same.

To put it in a nutshell:
- this change of API has 0 impact on the core of Dokuwiki
- there is no evidence that it would impact other code
- there doesn't seem to be a clean way to avoid this change

This commit fixes #3436

show more ...

test: run test in separate process in case of error

If there is an error when executing the method under test, then this
test caused the downstream test \remoteapicore_test::test_getBacklinks
to une

test: run test in separate process in case of error

If there is an error when executing the method under test, then this
test caused the downstream test \remoteapicore_test::test_getBacklinks
to unexpectedly fail. Probably, because the global plugin controller
would not have been reset to its original value.

Running this test in its own process ensures that it won't affect any
other test, even if it messes with the global state and doesn't clean up.

show more ...