add configuration for rector

A workflow should automatically suggest a new pull request with the
changes.

Initial fixes will not be applied from the auto generated PR but will be
added as piece by

add configuration for rector

A workflow should automatically suggest a new pull request with the
changes.

Initial fixes will not be applied from the auto generated PR but will be
added as piece by piece commits with rule updates to this branch.

show more ...

enforce content type on XML-RPC. addresses #3991

This ensures only text/xml or application/xml content types are accepted
when communicating with the XML-RPC API

increase required PHP version to 7.4

use local squid docker instance for proxy testing

added deprecated tag for phpQuery::newDocument()

for highlightin in IDE

extracted JS compressor into its own library

This moves our JavaScript compressor into its own composer dependency.

updated repo links

added test for #3924

Bug report says polish letters aren't deaccented correctly, but it seems
to work?

fix trim call in Mailer's name cleaning

The wrong quotes were used, turning what was meant to be a tab char into
a literal t.

fixes #3923

output full path when initializing savedir path fails

This will not only clean up double slashes etc. as mentioned in #3903
but will also output the full canonical path (starting at the filesystem
r

output full path when initializing savedir path fails

This will not only clean up double slashes etc. as mentioned in #3903
but will also output the full canonical path (starting at the filesystem
root) when showing an error on initializing the savedir paths. This
should make it easier to understand which path DokuWiki is trying to
access exactly.

show more ...

Fix unititialized string offset access in query parser

The code always tried to access positon 2 of the parsed token, even for
tokens shorter than that (like OR)

fixes #3896

Add mechanism to parse the Version data into its parts

This will be needed in the release automation I'm currently working on.

Properly quick search in titles with UTF-8 chars.

Fixes #3808

Revert "reset Event System in TestRequest"

This reverts commit d09a8e055b2b1ddb55da17403441e873517de553.

We have test that manipulate the event handler (eg. registering their
own events on that han

Revert "reset Event System in TestRequest"

This reverts commit d09a8e055b2b1ddb55da17403441e873517de553.

We have test that manipulate the event handler (eg. registering their
own events on that handler) which broke with above commit.

A better way needs to be found.

show more ...

reset Event System in TestRequest

To better simulate requests, event registration should be redone on each
simulated request.

use httpbingo for HTPP tests

This service is based on httpbin-go which seems to be better maintained
and should be easy to set up for ourselves if needed.

This also fixes a warning when the client

use httpbingo for HTPP tests

This service is based on httpbin-go which seems to be better maintained
and should be easy to set up for ourselves if needed.

This also fixes a warning when the client is reused with the
max_bodysize mechanism

show more ...

fix type hints for new php-dom-wrapper

Move PSR compliant tests to the apropriate namespaces

Having "inc" in the namespace is awkward. Instead the test class
namespaces now correspond to their real class namespaces.

With further refacto

Move PSR compliant tests to the apropriate namespaces

Having "inc" in the namespace is awkward. Instead the test class
namespaces now correspond to their real class namespaces.

With further refactorings we should get rid of most of the stuff in
tests/inc

this is a continuation of #3812

show more ...

Move IP functions into a class

Factor out IP address functions; all proxies must be trusted

replace phpquery by php-dom-wrapper #3308

This replaces the outdated phpquery library by the newer and maintained
php-dom-wrapper. Usage is similar but not a 1:1 replacement. phpQuery is
left in but

replace phpquery by php-dom-wrapper #3308

This replaces the outdated phpquery library by the newer and maintained
php-dom-wrapper. Usage is similar but not a 1:1 replacement. phpQuery is
left in but marked as deprecated.

show more ...

Update core code to make use of sexplode()

This makes use of our own explode mechanism everywhere were we expect a
fixed number of results.

add proper namespace to test classes

This adds the test namespace to those test classes that are already in
PSR4 format.

fix autoloading for tests

This replaces my attempt in 12ebce974be688ac34bf4389645d5fc7baa29cc7

The canonical namespace for DokuWiki core tests is dokuwiki/test/ and
this is mapped to _test/tests no

fix autoloading for tests

This replaces my attempt in 12ebce974be688ac34bf4389645d5fc7baa29cc7

The canonical namespace for DokuWiki core tests is dokuwiki/test/ and
this is mapped to _test/tests now in the autoloader.

This means the majority of tests is in the dokuwiki/test/inc namespace.

Mockfiles are located at _test/mock and have the namespace
dokuwiki/test/mock - if that's good or bad is debatable. I simply kept
it as it always has been. But there might be an argument for having mock
objects closer to the tests that use them (eg. right next to the test
files).

show more ...

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had

Remove the htmlok and phpok embedding options

Both options have grave security implications and novice users seem to
ignore advice about them. In the last decades I never came across a wiki
that had legitimate use of these options.

If someone needs the functionality, it can easily be added back using a
plugin. But I prefer to give users one less option to shoot themselves
in the foot.

Removal of the translations for the config strings can follow after this
has been merged.

show more ...