| a6fbb60b | 06-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
smaller icons, less vertical space |
| b6f1debd | 06-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
optimized SVGs
ran svgo over all the admin svg files to strip all unneeded cruft. |
| 40272563 | 06-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
created distinct create image, optimized images
I used svgo to strip all unneeded cruft from the svgs |
| fb03ffd3 | 06-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
made pageToolItem() more flexible
Now any arbitrary attributes can be passed as 4th argument. This way classes etc could be added by plugins. |
| db433680 | 06-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
adjust the event
This will open up the discussion from #236 again and I'm not sure how to solve this best.
The TEMPLATE_PAGETOOLS_DISPLAY event is very specific to the dokuwiki template in theory.
adjust the event
This will open up the discussion from #236 again and I'm not sure how to solve this best.
The TEMPLATE_PAGETOOLS_DISPLAY event is very specific to the dokuwiki template in theory. In practice many other templates implemented not only the same event but also use the same HTML (and often even the same CSS). Which makes the event more like a core event.
This branch now changes the HTML the event expects back from handlers. When merged it would immeadiately break all plugins implementing this event (and by broken I mean the layout/design of the template breaks).
Since the expected data changes, I would argue this should be a new event or at least be implemented in a way to not break the design by installing an old plugin and by giving the plugin a chance to know if it's running on the old or the new code.
This is what this commit does. By changing the view names, old plugins should not display (because they hopefull do not handle those views) but gives them an easy way to handle the old and new views in one plugin.
However, I'm not perfectly happy with it, yet.
The way I implemented the new SVG handling is by means of a new class dokuwiki\template\dokuwiki\tpl which provides a pageToolAction() method. Plugins could use this method to easily return the proper HTML for the pagetool items and we could adjust this method later on to make adjustments to the pagetools without breaking anything again.
However this method is template specific again. While it would possible for plugins to use this method even when the wiki runs another plugin emitting the event, it would be a bit weird.
A better way would be for the event to not expect HTML at all, but instead a data structure of the data currently passed to pageToolAction(). Templates could then decide to implement the event, but still render the data in a completely different way...
OTOH this means plugins are no longer free to add whatever they want into the pagetools. We once argued plugins might want to add submenus or other fancy stuff there. But in fact no plugin ever did.
If we decide to go this new way of making the event more of a first class citizen of template development, then we would probably have to move parts or all of the tpl class back to the core.
show more ...
|
| 07932c8c | 06-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
adjusted function name |
| fafff83c | 06-Feb-2017 |
Satoshi Sahara <sahara.satoshi@gmail.com> |
translation update |
| 4cd2074f | 05-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
fixed typo in function name |
| b4b0a666 | 05-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
proper action handling for pagetools
The whole pagetool items are now build in an extra helper class that can be reused by plugins. |
| f83f0fd0 | 05-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
support autoloading for templates
similar to what is possible for plugins, templates can now autoload namespaced classes, too. the namespace is dokuwiki\template\<templatename> |
| 5172d49d | 05-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
first very simple attempt at implementing svg pagetools
todos:
* edit action (and maybe others) use different icons depending on state, we can't rely on passing $post * media details screen not a
first very simple attempt at implementing svg pagetools
todos:
* edit action (and maybe others) use different icons depending on state, we can't rely on passing $post * media details screen not adjusted, yet * no RTL styles * no focus/active styles * the event needs to be adjusted (maybe throw it away and do a new one) * some icons are not good (create = edit) * possibly more
show more ...
|
| 71de5572 | 05-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
changed embedSVG to inlineSVG and make it return contents
This makes it more flexible to use on the expense of needing one echo more. |
| 653c4606 | 04-Feb-2017 |
hznupeter <qiujiongtao@163.com> |
translation update |
| 70635395 | 03-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
fix pass by reference bug identified by scrutinizer
$pagelog->getRevisions(-1, 1) cannot be passed to array_pop() as the parameter $array expects a reference. |
| 472b5ca1 | 03-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
removed commented out code |
| 56bf57c6 | 03-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
remove unused code |
| 427bf9a2 | 03-Feb-2017 |
Andreas Gohr <andi@splitbrain.org> |
do not deliver scripts to ie<9 fixes #1816
All script tags are now surrounded by conditional comments to tell Internet Explorer 8 and lower to not even bother trying to load the JavaScript. |
| ad91274c | 31-Jan-2017 |
Andreas Gohr <andi@splitbrain.org> |
replaced broken link with wayback archive. fixes #1814 |
| ad4b3247 | 31-Jan-2017 |
Andreas Gohr <andi@splitbrain.org> |
typo fix |
| d1a3148a | 31-Jan-2017 |
Andreas Gohr <andi@splitbrain.org> |
removed unneeded clearer |
| 5d2e38cb | 31-Jan-2017 |
Andreas Gohr <andi@splitbrain.org> |
use lower case class names |
| 220b8a20 | 31-Jan-2017 |
Andreas Gohr <andi@splitbrain.org> |
improve admin styling
* use inline-block instead of flexbox * fix RTL alignments |
| 6dfd365d | 31-Jan-2017 |
Andreas Gohr <andi@splitbrain.org> |
Revert "removed the no longer used admin PNG icons"
This reverts commit b8b60fdbcef5123b187a73a7031820d0ea6a12be.
The images are now to be seen as deprecated but will remain for a little longer. Th
Revert "removed the no longer used admin PNG icons"
This reverts commit b8b60fdbcef5123b187a73a7031820d0ea6a12be.
The images are now to be seen as deprecated but will remain for a little longer. They will be released in the future.
show more ...
|
| 0849fa88 | 31-Jan-2017 |
Andreas Gohr <andi@splitbrain.org> |
more cleanup in embedSVG
now comments and line breaks between tags are removed |
| 44f5d1c1 | 24-Jan-2017 |
Andreas Gohr <gohr@cosmocode.de> |
misspelled foot |