change Tokenizer static utility

frequently used in ajax call, singleton is not effective to reduce multiple instantiations.

fix scrutinizer claims

instantiate *Index with numeric page id

will reduce access to static $pidCache

change Index objects to non-singleton

Indexer, FulltextIndex, MetadataIndex uses common directory to store *.idx files, but this does not mean they should be singleton objects to avoid lock confrict

change Index objects to non-singleton

Indexer, FulltextIndex, MetadataIndex uses common directory to store *.idx files, but this does not mean they should be singleton objects to avoid lock confrictions.

show more ...

avoid null in addMetaKeys()

Just ignore $value argument if $key argument is array .
Ignore enpty key of $key argument.
Ensure to treat any null value of $key array as empty string.

remove unnecessary if blocks

getPID(), saveIndex(), saveIndexKey(), getPageWords() return always true, otherwise exceptions.

throw IndexWriteException in saveIndex()/saveIndexkey()

update phpdoc

deprecate html_form()

encourage plugin devs to use new Form class

use new event EDIT_FORM_ALTERNATE

to prevent breaks in old HTML_EDIT_FORMSELECTION event handler, such as edittable plugin

replace user errors with exceptions

Exceptions are better to handle than errors. What I don't like is that
we now have an unfortunate mix of return code and exception signalling
for errors. Some met

replace user errors with exceptions

Exceptions are better to handle than errors. What I don't like is that
we now have an unfortunate mix of return code and exception signalling
for errors. Some methods still return false for errors while others
now throw exceptions (always returning true otherwise).

show more ...

remove html_softbreak_callback()

re-declare deprecated function html_edit_form()

call dbg_deprecated(), even this function lost compatibility because its argument $param['form'] has changed to hold Form\Form object

re-declare deprecated function html_li_default()

fix missing return

media: Fix media_resize_image cache check

The check was backwards, and it also caused a failure when there is no
cache file (mtime=0) because the function would still return the path to
the nonexist

media: Fix media_resize_image cache check

The check was backwards, and it also caused a failure when there is no
cache file (mtime=0) because the function would still return the path to
the nonexistent cache file.

show more ...

consistent html_buildlist() usage

see usage of html_buildlist in plugin acl (admin and action component)

re-declare deprecated functions for backward compatibility

`dbg_deprecated()` is called in `html_diff_head()`, `html_diff_navigation()`, `html_diff_navigationlink()`, and following functions:

* `h

re-declare deprecated functions for backward compatibility

`dbg_deprecated()` is called in `html_diff_head()`, `html_diff_navigation()`, `html_diff_navigationlink()`, and following functions:

* `html_denied()` is not used any plugins, but added fallback just in case.
* `html_locked()` is used by one third-party plugin (AjaxEdit), fallback should be added.
* `html_insert_softbreaks()` is used by one third-party plugin (TOS, terms of service), fallback should be added.

show more ...

Update translation

選擇 =>Traditional Chinese
选择 => Simplified Chinese

translation update

don't crush tables too narrow. fixes #3250

This ensures that the table wrapper has at least 50% of the page width
available. This allows small tables still be besides floating elements
like images o

don't crush tables too narrow. fixes #3250

This ensures that the table wrapper has at least 50% of the page width
available. This allows small tables still be besides floating elements
like images or the TOC, but larger tables will get the full width.

show more ...

add dbg_deprecated() calls

use Slika for image resizing and cropping

This replaces our own resize/crop function by the Slika library.

This is not yet ideal, as there is quite a bit duplicated code between
media_resize and me

use Slika for image resizing and cropping

This replaces our own resize/crop function by the Slika library.

This is not yet ideal, as there is quite a bit duplicated code between
media_resize and media_crop now. Ideally these two should be replaced by
a single method handling both. I'm just not sure where to best put it
yet.

Using Slika introduces two new features:

* auto rotation based on EXIF #3059
* support for webp #3238

show more ...

added Slika as dependency

translation update